Implement :func ABI for calling GPUCompiler emitted code
#71
+52
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ABI is always ccallable, unlike the `:specfunc` ABI which frequently is not. In the future, it would be good to selectively re-enable the `:specfunc` ABI for types that are safely ccallable. The `:specfunc` ABI is interesting to us not just because it's fast. It allows us to frequently avoid allocations for passing arguments / return values, unlike the `:func` ABI which (almost) always allocates.
topolarity
commented
Feb 1, 2024
| else | ||
| argsv = Any[args...] | ||
| GC.@preserve argsv begin | ||
| return ccall(f.f_ptr, Any, (Any, Ptr{Any}, UInt32), f.func, pointer(argsv), length(args)) |
There was a problem hiding this comment.
@gbaraldi please double-check my ccall/ABI-foo here
topolarity
commented
Feb 1, 2024
| # compile the function | ||
| cache = compiler_cache | ||
| source = GPUCompiler.methodinstance(F, tt) | ||
| rt = Core.Compiler.return_type(f, tt) | ||
|
|
||
| specsig = false # TODO: selectively re-enable after reviewing `uses_specsig` in codegen.cpp |
There was a problem hiding this comment.
Here is where we should scan the types and see if there is anything that we cannot correctly translate for specsig.
That might be just checking for Union/UnionAll? I need to stare at codegen for a while before I'm convinced, though.
topolarity
force-pushed
the
ct/invoke-api
branch
2 times, most recently
from
1a4a72e
to
7ed4ef8
Compare
Merged
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ABI is always ccallable, unlike the
:specfuncABI which frequently is not.However, this ABI comes with a trade-off of introducing allocations (almost) always for function entry/exit. For that reason, we should re-enable the
:specfuncABI as soon as we can on as many types as possible.Resolves #70