Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walkdir from Base. #180

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Add walkdir from Base. #180

merged 1 commit into from
Mar 30, 2016

Conversation

MichaelHatherly
Copy link
Member

Based directly on JuliaLang/julia#13707. Any opposition to adding this?

Tests pass locally on 0.3.13-pre+5, 0.4.6-pre+4, and 0.5.0-dev+3258.

@tkelman
Copy link
Contributor

tkelman commented Mar 30, 2016

needs an end of file rebase. no objection here

@MichaelHatherly
Copy link
Member Author

Rebased. Should we hold off on the latest tag, JuliaLang/METADATA.jl#4884, until this is merged?

@tkelman
Copy link
Contributor

tkelman commented Mar 30, 2016

Not sure what you mean hold off, it was already tagged but not merged yet. More work to change that than just do another tag after merging this.

@MichaelHatherly
Copy link
Member Author

More work to change that than just do another tag after merging this.

Yes, not sure why I thought that would be simpler than just doing another tag afterwards.

@MichaelHatherly MichaelHatherly merged commit 16733dc into JuliaLang:master Mar 30, 2016
@MichaelHatherly MichaelHatherly deleted the mh/walkdir branch March 30, 2016 14:41
martinholters pushed a commit to martinholters/Compat.jl that referenced this pull request Jul 13, 2016
Fix concat deprecation warning in `cut`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants