Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define X_n variables on entry to function generated by nsplat/ngenerate #42

Merged
merged 1 commit into from
Feb 9, 2015

Conversation

simonster
Copy link
Member

This appears to fix DataArrays. cc @timholy

@timholy
Copy link
Sponsor Member

timholy commented Feb 9, 2015

LGTM. As you surely know, you can also use the @nexprs N (d->X_d = ...) construct, but given that you have to splice in the symbol your version is probably easier. Merge at will. (And then we should tag a new release.)

@simonster
Copy link
Member Author

Hmm, it seems like @nexprs might be a better idea if X is a heterogeneously typed tuple, since it looks like X_1, X_2 = X doesn't give us proper type information.

@simonster simonster force-pushed the sjk/ngenerate branch 2 times, most recently from 31e9d1e to cc077d6 Compare February 9, 2015 21:18
@timholy
Copy link
Sponsor Member

timholy commented Feb 9, 2015

Nice. I hadn't remembered that distinction, but it makes sense.

simonster added a commit that referenced this pull request Feb 9, 2015
Define X_n variables on entry to function generated by nsplat/ngenerate
@simonster simonster merged commit 94423b4 into master Feb 9, 2015
@simonster
Copy link
Member Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants