RFC: Neither advertise full keyword of qr nor test it on 0.7
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `thin` keyword was replaced by `full`, but later abandoned completely. To keep code working on Julia 0.6 that had adapted to `full`, the interface is retained on Julia 0.6, but neither tested on 0.7 (where it doesn't work) nor advertised in the README.
|
CC @Sacha0, @fredrikekre - you had something like this in mind? |
fredrikekre
approved these changes
May 29, 2018
|
Just noticed that some comments in the code would be helpful in the future, will update momentarily... |
|
I'm not expecting tests to pass on the latest commit due to #558, but it's an NFC, so I'll merge this later today unless objections are voiced. |
|
Much thanks @martinholters! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
thinkeyword was replaced byfull, but later abandoned completely. To keep code working on Julia 0.6 that had adapted tofull, the interface is retained on Julia 0.6, but neither tested on 0.7 (where it doesn't work) nor advertised in the README.Closes #556.