Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mergewith[!](combine, dicts...) #694

Merged
merged 4 commits into from Apr 29, 2020
Merged

Add mergewith[!](combine, dicts...) #694

merged 4 commits into from Apr 29, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Apr 22, 2020

Quoting README:

  • mergewith(combine, dicts...) and mergewith!(combine, dicts...) are like merge(combine, dicts...) and merge!(combine, dicts...) but without the restriction that the argument combine must be a Function ([#34296]). (since Compat 3.9.0).

Ref: JuliaLang/julia#34296

martinholters
martinholters requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

src/Compat.jl Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
tkf and others added 3 commits April 27, 2020 14:40
@tkf
Copy link
Member Author

tkf commented Apr 27, 2020

@martinholters Thanks for the review! I updated the patch.

martinholters
martinholters approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Will merge soon unless someone objects or beats me to it.

@martinholters martinholters merged commit af45b90 into JuliaLang:master Apr 29, 2020
@tkf tkf deleted the mergewith branch April 29, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfourquet rfourquet rfourquet approved these changes

@martinholters martinholters martinholters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkf @rfourquet @martinholters