end-to-end tests for #167 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 91.29% 92.47% +1.17%
==========================================
Files 5 5
Lines 494 518 +24
==========================================
+ Hits 451 479 +28
+ Misses 43 39 -4
Continue to review full report at Codecov.
|
|
Right, so this is good for coverage since now we're hitting all the code paths, but what I'd ideally like is a way to tell from the response whether the request was chunked or not. I was poking around the response headers from httpbingo yesterday but didn't find a way to tell this. |
These only add one callback so having them be plural is weird.
This adds end-to-end tests for the changes introduced in #167. Verbose mode is switched off for these tests, but switching it on would show that not setting content-length headers results in chunked transfer encoding while setting it prevents that. Both tests should pass.
This combines the functionality from the previous two commits to not only trigger both chunked and non-chunked uploads, but also test for that difference by capturing and inspecting the debug events.
StefanKarpinski
force-pushed
the
tan/chunkedtransfer
branch
from
66e4182
to
4e0408a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds end-to-end tests for the changes introduced in #167.
Verbose mode is switched off for these tests, but switching it on would show that not setting content-length headers results in chunked transfer encoding while setting it prevents that. Both tests should pass.
fixes #169