-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warnings on 0.4 #22
Conversation
As a bonus, takes care of the Task switching bug that's keeping DataFrames tests from running on 0.4
throw(Error("Expecting an ArgumentError or similar")) | ||
catch e | ||
@test isa(e, ArgumentError) || contains(e.msg, "too many arguments") | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't working on 0.3 or 0.4 on Travis. Locally, it's an ArgumentError
on 0.4 and and an Error
with the above message on 0.3. Any hints as to the inconsistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the generic error's thrown in base we made more specific as to the actual type of the error (ArgumentError in this case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got that -- just confused why I'm getting those locally and ZError
s on Travis for both 0.3. and 0.4. Could add more logic in the catch block, just hoping I could avoid haphazardly papering over an issue.
Argh, forgot the requisite Compat patch was still waiting on Travis. Restarted -- apologies for the noise. |
Error on 0.4 belongs to JuliaParser:
Passes locally on 0.4. |
Hmm, fixing this is going to be a bit of a pain. I don't think I will get to it tonight. |
Since the tests passed (no |
Yes, go ahead. |
I don't have the permissions (to merge here, fine for metadata). |
Remove deprecation warnings on 0.4
Thanks! |
As a bonus, takes care of the Task switching bug that's keeping DataFrames tests from running on 0.4