Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings on 0.4 #22

Merged
merged 2 commits into from
Mar 19, 2015
Merged

Conversation

garborg
Copy link
Contributor

@garborg garborg commented Mar 17, 2015

As a bonus, takes care of the Task switching bug that's keeping DataFrames tests from running on 0.4

As a bonus, takes care of the Task switching bug that's keeping DataFrames tests from running on 0.4
@coveralls
Copy link

Coverage Status

Coverage decreased (-49.93%) to 3.76% when pulling a506d5e on garborg:track04 into 810f370 on JuliaLang:master.

throw(Error("Expecting an ArgumentError or similar"))
catch e
@test isa(e, ArgumentError) || contains(e.msg, "too many arguments")
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working on 0.3 or 0.4 on Travis. Locally, it's an ArgumentError on 0.4 and and an Error with the above message on 0.3. Any hints as to the inconsistency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the generic error's thrown in base we made more specific as to the actual type of the error (ArgumentError in this case).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got that -- just confused why I'm getting those locally and ZErrors on Travis for both 0.3. and 0.4. Could add more logic in the catch block, just hoping I could avoid haphazardly papering over an issue.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.69%) to 0.0% when pulling 9a066f1 on garborg:track04 into 810f370 on JuliaLang:master.

@garborg
Copy link
Contributor Author

garborg commented Mar 18, 2015

Argh, forgot the requisite Compat patch was still waiting on Travis. Restarted -- apologies for the noise.

@coveralls
Copy link

Coverage Status

Coverage increased (+15.39%) to 69.08% when pulling c1f70c7 on garborg:track04 into 810f370 on JuliaLang:master.

@garborg
Copy link
Contributor Author

garborg commented Mar 18, 2015

Error on 0.4 belongs to JuliaParser:

ERROR: LoadError: LoadError: LoadError: error in method definition: function Base.parse must be explicitly imported to be extended
...
while loading /home/travis/.julia/v0.4/JuliaParser/src/parser.jl, in expression starting on line 1864

Passes locally on 0.4.

@jakebolewski
Copy link
Contributor

Hmm, fixing this is going to be a bit of a pain. I don't think I will get to it tonight.

@garborg
Copy link
Contributor Author

garborg commented Mar 19, 2015

Since the tests passed (no JuliaParser in the dependency tree) and the hang up was in Coveralls submission, does it makes sense to merge this in the meantime so I can tag a patch?

@jakebolewski
Copy link
Contributor

Yes, go ahead.

@garborg
Copy link
Contributor Author

garborg commented Mar 19, 2015

I don't have the permissions (to merge here, fine for metadata).

jakebolewski added a commit that referenced this pull request Mar 19, 2015
Remove deprecation warnings on 0.4
@jakebolewski jakebolewski merged commit df5704c into JuliaIO:master Mar 19, 2015
@garborg
Copy link
Contributor Author

garborg commented Mar 19, 2015

Thanks!

@garborg garborg deleted the track04 branch March 19, 2015 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants