Bandaid for gzseek bug on Windows #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure on nightly does not seem related to me (?). |
use rewind if possible see madler/zlib#95
carlobaldassi
force-pushed
the
cb/gzseekwinfix
branch
from
0cca7ad
to
f99b0ed
Compare
1 similar comment
|
Based on my tests, the updated version should be able to fix the issue under Windows in all situations, not just seeking to zero. Any objections to merging this? |
|
Go for it! On Friday, April 10, 2015, Carlo Baldassi notifications@github.com wrote:
|
carlobaldassi
added a commit
that referenced
this pull request
Apr 10, 2015
Bandaid for gzseek bug on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlib 1.2.8 has a bug on Windows, see madler/zlib#95.
This is a bandaid for the common case of rewinding a stream. At least, in this way it would fix the issue for FastaIO.jl, which uses GZip.