Add logging override for 0.7 #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, although things seem to be getting captured, they do not seem to be getting communicated to the browser. |
Julia 0.7 changed the `String()` constructor to deplete `Vector{UInt8}`
arguments, so we must `copy()` them first to avoid clobbering.
|
Ah, found it. |
|
See also JuliaLang/julia#26798. |
Merged
|
Closing in favor of #671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.7 has a new logging infrastructure, which saves the output stream (e.g.
Base.stderr) within itself. We need to override that if we want to receive things likewarn()orinfo(). This is not the most elegant way this could be done, but it does seem to work (and passes its own test suite on 0.7)