Improve error message for closing tokens in parse_atom (#261)

Fixes #114
JuliaLang · Apr 29, 2023 · 7445401 · 7445401
1 parent 96c9440
commit 7445401
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/parser.jl b/src/parser.jl
@@ -3557,7 +3557,7 @@ function parse_atom(ps::ParseState, check_identifiers=true)
         # )  ==>  error
         msg = leading_kind == K"EndMarker" ?
               "premature end of input" :
-              "unexpected closing token"
+              "unexpected `$(untokenize(leading_kind))`"
         bump_invisible(ps, K"error", error=msg)
     else
         bump(ps, error="invalid syntax atom")

diff --git a/test/diagnostics.jl b/test/diagnostics.jl
@@ -24,6 +24,9 @@ end
     # TODO: better range
 	@test diagnostic("@A.\$x a") ==
         Diagnostic(6, 5, :error, "invalid macro name")
+
+	@test diagnostic("a, , b") ==
+        Diagnostic(4, 3, :error, "unexpected `,`")
 end
 
 @testset "parser warnings" begin