Throw Meta.ParseError from Meta.parse() in Julia 1.10 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New hooks added in JuliaLang/julia#46372 allow us to * Add `JuliaSyntax.ParseError` as the new detail field of `Meta.ParseError`, preserving the detailed error information and ability to overload `showerror`, without disrupting `Base` too much. * Return `Expr(:incomplete, Meta.ParseError(...))` for incomplete expressions while having `incomplete_tag` still work.
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 96.79% 96.74% -0.05%
==========================================
Files 14 14
Lines 4083 4088 +5
==========================================
+ Hits 3952 3955 +3
- Misses 131 133 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New hooks added in JuliaLang/julia#46372 allow us to
JuliaSyntax.ParseErroras the new detail field ofMeta.ParseError, preserving the detailed error information and ability to overloadshowerror, without disruptingBasetoo much.Expr(:incomplete, Meta.ParseError(...))for incomplete expressions while havingincomplete_tagstill work.