Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parentheses in import paths and macro names #226

Merged
merged 2 commits into from Mar 22, 2023
Merged

Conversation

c42f
Copy link
Member

@c42f c42f commented Mar 22, 2023

  • Allow parens in import paths like import A.(:+)
  • Fix parsing of parenthesized macro names in macro calls like @(A)

Part of #134

Some packages use this syntax, even though it's apparently pointless!
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #226 (45860e0) into main (92eac55) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   96.12%   96.31%   +0.18%     
==========================================
  Files          15       15              
  Lines        3896     3904       +8     
==========================================
+ Hits         3745     3760      +15     
+ Misses        151      144       -7     
Impacted Files Coverage Δ
src/expr.jl 100.00% <100.00%> (ø)
src/parser.jl 98.00% <100.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@c42f c42f merged commit 8cad384 into main Mar 22, 2023
21 checks passed
@c42f c42f deleted the c42f/various-fixes branch March 22, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant