-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "not your fault" hint to the fallback to flisp error #358
Conversation
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 96.56% 95.76% -0.80%
==========================================
Files 14 13 -1
Lines 4161 3895 -266
==========================================
- Hits 4018 3730 -288
- Misses 143 165 +22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, let's do this! I'd use a triple quoted string rather than *
but either way :-)
How about "This is not your fault" (i.e. needing to send a bug report)? JuliaSyntax.jl should parse legal, and all illegal code, so it's never the users fault?! Though if illegal could have gotten an ERROR message from JuliaSyntax.jl, and then in that sense the users fault. |
Agreed, triple quoted is better. @PallHaraldsson I don't understand what you're saying. Yes, JuliaSyntax should be able to handle any input string, legal or illegal, but like all nontrivial software, JuliaSyntax has bugs. This PR improves the user experience when folks hit those bugs and encourage them to report the bugs they hit so we can fix them. |
Yes it has bugs, and we want them reported, but with "probably" it seems like you're blaming the user for that. It didn't seem necessary. I want an error/clarification, just thought the wording could be adjusted. |
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
Adds "This is probably not your fault, please submit a bug report (https://github.com/JuliaLang/JuliaSyntax.jl/issues)" to the long message when JuliaSytnax has an internal bug.
From @topolarity and @vchuravy 's commentary here #340