Changing types in parse_key! call

[joshbode]

Change Void pointers to Cuchar pointers in line with the signature
of mbedtls_pk_parse_key

Addressing issue #71

[malmaud]

Looks like it failed CI.

[codecov-io]

Current coverage is 73.02% (diff: 50.00%)

Merging #72 into master will increase coverage by 2.25%

@@             master        #72   diff @@
==========================================
  Files            10         10          
  Lines           390        393     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            276        287    +11   
+ Misses          114        106     -8   
  Partials          0          0          

Powered by Codecov. Last update 4a92329...5dc0fb6

[joshbode]

Strange - it's building fine for Linux/OS X. Windows build is failing with:

ERROR: LoadError: ccall: could not find function mbedtls_pk_parse_key in library C:\projects\julia\bin\libmbedtls.DLL

[joshbode]

OK - that last commit seems to have done the trick: changed MBED_TLS -> MBED_CRYPTO for the call.
Not sure why it didn't affect the Linux/OS X build, but they're both working.

[malmaud]

Thanks!

[joshbode]

Thanks for that :)

Guessing this is why the build wasn't failing on OS X at least (libmbedtls.dylib depends on libmbedcrypto.dylib anyway):

    $ otool -L /Users/josh/.julia/v0.5/Homebrew/deps/usr/lib/libmbedtls.dylib
    /Users/josh/.julia/v0.5/Homebrew/deps/usr/lib/libmbedtls.dylib:
        /Users/josh/.julia/v0.5/Homebrew/deps/usr/opt/mbedtls/lib/libmbedtls.10.dylib (compatibility version 10.0.0, current version 2.3.0)
        @loader_path/libmbedx509.0.dylib (compatibility version 0.0.0, current version 2.3.0)
        @loader_path/libmbedcrypto.0.dylib (compatibility version 0.0.0, current version 2.3.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)

[joshbode]

Could you please tag a release with this code if you have a chance?

[tkelman]

Please don't drop testing of a version of julia unless you also drop support for it in REQUIRE. Turning off testing alone is a very bad idea.

[joshbode]

Good point - sorry, I missed that.
Looks Like @quinnj cleaned it up subequently in e8f789d

[tkelman]

Yes, but he also merged several other changes and included a "last 0.4-supporting tag" which did not go through CI on 0.4