ensure threading is disabled where not allowed #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/set_1_thread
branch
from
0dca873
to
b8eb796
Compare
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 83.00% 83.00%
=======================================
Files 3 3
Lines 665 665
=======================================
Hits 552 552
Misses 113 113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is the wrong approach because threads should always respect what the user requested |
|
I don't think this is necessarily wrong --- we can certainly choose how many threads to use in a process that we spawn for the purpose of building a system image. |
|
As discussed, a proposal to fix this upstream JuliaLang/julia#48592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like threading might not be allowed/expected on 1.9+ in some of these stages, which was causing #778.
@vtjnash is that right?
This fixes/patches #778 in cases where the user has
JULIA_NUM_THREADSset to > 1Testing locally, this fixes it in the sense that CPU load goes down to 100% per precompile task.
However, precompilation still takes a lot longer than it should. It seems like the 1 active thread is spinning or something