Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not export macro, just make it public. #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not export macro, just make it public. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Public.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,12 @@ function _is_valid_macro_expr(expr::Expr)
return true
end

# TODO: figure out if we actually want to `export`,
# or if we just want to mark as public.
export @public
# Do not export the macro, just declare it as public. This macro is
# only useful in packages and it is bad practice to import every
# symbol with an open-ended `using` in package code, since it can cause
# future import conflicts. Not that it is very likely to happen with
# this specific package and macro, but we shouldn't encourage bad
# practices.
@public @public

end # module Public
Loading