Skip to content

Commit

Permalink
Add a NEWS entry for #22532: Char concatenation using * (#22766)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ararslan
ararslan committed Jul 15, 2017
1 parent ac51e03 commit 0b2774e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
View file
Expand Up @@ -108,6 +108,8 @@ Library improvements

* A new `@macroexpand1` macro for non recursive macro expansion ([#21662]).

* `Char`s can now be concatenated with `String`s and/or other `Char`s using `*` ([#22532]).

Compiler/Runtime improvements
-----------------------------

Expand Down Expand Up @@ -991,4 +993,5 @@ Command-line option changes
[#22245]: https://github.com/JuliaLang/julia/issues/22245
[#22310]: https://github.com/JuliaLang/julia/issues/22310
[#22523]: https://github.com/JuliaLang/julia/issues/22523
[#22532]: https://github.com/JuliaLang/julia/issues/22532
[#22732]: https://github.com/JuliaLang/julia/issues/22732

7 comments on commit 0b2774e

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

@tkelman
Copy link
Contributor

@tkelman tkelman commented on 0b2774e Jul 15, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something merged today may have broken the build HDF5?

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@ararslan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess whatever the issue was has been fixed?

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, I remember JuliaCI/BaseBenchmarks.jl#83 now - intermittent I think

Please sign in to comment.