Skip to content

Commit

Permalink
add news for #26858 and #26859 [ci skip] (#26869)
Browse files Browse the repository at this point in the history
  • Loading branch information
@JeffBezanson
JeffBezanson committed Apr 20, 2018
1 parent 23b08c5 commit 1c5ed70
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,12 @@ This section lists changes that do not have deprecation warnings.
* `parse(::Type, ::Char)` now uses a default base of 10, like other number parsing
methods, instead of 36 ([#26576]).

* `isequal` for `Ptr`s now compares element types; `==` still compares only addresses
([#26858]).

* `widen` on 8- and 16-bit integer types now widens to the platform word size (`Int`)
instead of to a 32-bit type ([#26859]).

Library improvements
--------------------

Expand Down

9 comments on commit 1c5ed70

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruh roh

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something with isbitstype seems to have royally rekt Nanosoldier:

Internal error: encountered unexpected error in runtime:
MethodError(f=typeof(Core.Compiler.isbitstype)(), args=(Core.Compiler.Const(val=Base.RefArray{Ptr{Nothing}, Array{Ptr{Nothing}, 1}, Nothing}, actual=false),), $
orld=0x0000000000000f91)
rec_backtrace at /home/nanosoldier/workdir/tmp2y6Ykc/src/stackwalk.c:94
record_backtrace at /home/nanosoldier/workdir/tmp2y6Ykc/src/task.c:246
jl_throw at /home/nanosoldier/workdir/tmp2y6Ykc/src/task.c:577
jl_method_error_bare at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:1596
jl_method_error at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:1614
jl_lookup_generic_ at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2144 [inlined]
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2164
process_immutable_preserve at ./compiler/ssair/passes.jl:192
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2167
getfield_elim_pass! at ./compiler/ssair/passes.jl:236
run_passes at ./compiler/ssair/driver.jl:168
optimize at ./compiler/optimize.jl:294
typeinf at ./compiler/typeinfer.jl:440
typeinf_edge at ./compiler/typeinfer.jl:137
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2167
abstract_call_method at ./compiler/abstractinterpretation.jl:284
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2167
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:78
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2167
abstract_call at ./compiler/abstractinterpretation.jl:672
jl_apply_generic at /home/nanosoldier/workdir/tmp2y6Ykc/src/gf.c:2167
abstract_eval_call at ./compiler/abstractinterpretation.jl:701
abstract_eval at ./compiler/abstractinterpretation.jl:773

There are a whole lot of messages like this

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/JuliaCI/BaseBenchmarkReports/blob/d17e02c1460caa2aaf3c2de3c2c60e8eda68979d/daily_2018_4_22/logs/1c5ed7082516c8a8c259907ceef908ba0c9d2107_primary.err#L140

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly related to #26859, maybe? What do you think, @JeffBezanson?

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the new ssair passes attempting to run?

Please sign in to comment.