Skip to content

Commit

Permalink
inference: avoid adding duplicate edges as invoke targets (#53121)
Browse files Browse the repository at this point in the history
This was inefficient, though not wrong.

Fixes #53020
  • Loading branch information
vtjnash authored and aviatesk committed Jan 31, 2024
1 parent 675e219 commit 1fbca96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/compiler/ssair/inlining.jl
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ function compileable_specialization(mi::MethodInstance, effects::Effects,
end
end
add_inlining_backedge!(et, mi) # to the dispatch lookup
push!(et.edges, method.sig, mi_invoke) # add_inlining_backedge to the invoke call
mi_invoke !== mi && push!(et.edges, method.sig, mi_invoke) # add_inlining_backedge to the invoke call, if that is different
return InvokeCase(mi_invoke, effects, info)
end

Expand Down

0 comments on commit 1fbca96

Please sign in to comment.