Merge pull request #37222 from nilshg/patch-1

Add missing support for addition and subtraction
JuliaLang · Aug 31, 2020 · 2a96176 · 2a96176 · nanosoldier · Aug 31, 2020
2 parents 0a77e07 + 8631987
commit 2a96176
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/stdlib/Dates/src/arithmetic.jl b/stdlib/Dates/src/arithmetic.jl
@@ -84,6 +84,12 @@ end
 (-)(x::Time, y::TimePeriod) = return Time(Nanosecond(value(x) - tons(y)))
 (+)(y::Period, x::TimeType) = x + y
 
+# Missing support
+(+)(x::AbstractTime, y::Missing) = missing
+(+)(x::Missing, y::AbstractTime) = missing
+(-)(x::AbstractTime, y::Missing) = missing
+(-)(x::Missing, y::AbstractTime) = missing
+
 # AbstractArray{TimeType}, AbstractArray{TimeType}
 (-)(x::OrdinalRange{T}, y::OrdinalRange{T}) where {T<:TimeType} = Vector(x) - Vector(y)
 (-)(x::AbstractRange{T}, y::AbstractRange{T}) where {T<:TimeType} = Vector(x) - Vector(y)

diff --git a/stdlib/Dates/test/arithmetic.jl b/stdlib/Dates/test/arithmetic.jl
@@ -499,4 +499,13 @@ end
     end
 end
 
+@testset "Missing arithmetic" begin
+    for t ∈ [Date, Time, Day, Month, Week, Year, Hour, Microsecond, Millisecond, Minute, Nanosecond, Second]
+        @test ismissing(t(1) + missing)
+        @test ismissing(missing + t(1))
+        @test ismissing(t(1) - missing)
+        @test ismissing(missing - t(1))
+    end
+end
+
 end