Merge pull request #11317 from lostanlen/patch-1

Avoid printing the banner while testing it

test/version.jl

@@ -1,9 +1,9 @@
 # This file is a part of Julia. License is MIT: http://julialang.org/license
 
 # parsing tests
-@test v"1" == VersionNumber(1)
-@test v"2.1" == VersionNumber(2, 1)
-@test v"3.2.1" == VersionNumber(3, 2, 1)
+@test v"2" == VersionNumber(2)
+@test v"3.2" == VersionNumber(3, 2)
+@test v"4.3.2" == VersionNumber(4, 3, 2)
 
 @test v"2-" == VersionNumber(2, 0, 0, ("",), ())
 @test v"3.2-" == VersionNumber(3, 2, 0, ("",), ())
@@ -13,9 +13,9 @@
 @test v"3.2-1" == VersionNumber(3, 2, 0, (1,), ())
 @test v"4.3.2-1" == VersionNumber(4, 3, 2, (1,), ())
 
-@test v"1-a" == VersionNumber(1, 0, 0, ("a",), ()) == v"1a"
-@test v"2.1-a" == VersionNumber(2, 1, 0, ("a",), ()) == v"2.1a"
-@test v"3.2.1-a" == VersionNumber(3, 2, 1, ("a",), ()) == v"3.2.1a"
+@test v"2-a" == VersionNumber(2, 0, 0, ("a",), ()) == v"2a"
+@test v"3.2-a" == VersionNumber(3, 2, 0, ("a",), ()) == v"3.2a"
+@test v"4.3.2-a" == VersionNumber(4, 3, 2, ("a",), ()) == v"4.3.2a"
 
 @test v"2-a1" == VersionNumber(2, 0, 0, ("a1",), ()) == v"2a1"
 @test v"3.2-a1" == VersionNumber(3, 2, 0, ("a1",), ()) == v"3.2a1"
@@ -41,9 +41,9 @@
 @test v"3.2+1" == VersionNumber(3, 2, 0, (), (1,))
 @test v"4.3.2+1" == VersionNumber(4, 3, 2, (), (1,))
 
-@test v"1+a" == VersionNumber(1, 0, 0, (), ("a",))
-@test v"2.1+a" == VersionNumber(2, 1, 0, (), ("a",))
-@test v"3.2.1+a" == VersionNumber(3, 2, 1, (), ("a",))
+@test v"2+a" == VersionNumber(2, 0, 0, (), ("a",))
+@test v"3.2+a" == VersionNumber(3, 2, 0, (), ("a",))
+@test v"4.3.2+a" == VersionNumber(4, 3, 2, (), ("a",))
 
 @test v"2+a1" == VersionNumber(2, 0, 0, (), ("a1",))
 @test v"3.2+a1" == VersionNumber(3, 2, 0, (), ("a1",))
@@ -77,17 +77,25 @@
 
 @test_throws ArgumentError VersionNumber(4, 3, 2, (), ("", 1))
 
+# show
+io = IOBuffer()
+show(io,v"4.3.2+1.a")
+@test length(takebuf_string(io)) == 12
+
 # conversion from Int
 @test convert(VersionNumber, 2) == v"2.0.0"
 
 # conversion from Tuple
 @test convert(VersionNumber, (2,)) == v"2.0.0"
 @test convert(VersionNumber, (3, 2)) == v"3.2.0"
 
+# conversion from AbstractString
+@test convert(VersionNumber, "4.3.2+1.a") == v"4.3.2+1.a"
+
 # typemin and typemax
 @test typemin(VersionNumber) == v"0-"
 @test typemax(VersionNumber) ==
-  VersionNumber(typemax(Int),typemax(Int),typemax(Int),(),("",))
+  VersionNumber(typemax(Int), typemax(Int), typemax(Int), (), ("",))
 
 # issupbuild
 import Base.issupbuild
@@ -106,7 +114,7 @@ import Base.issupbuild
 @test ~issupbuild(v"4.3.2+1a")
 
 # basic comparison
-VersionNumber(2,3,1) == VersionNumber(Int8(2),UInt32(3),Int32(1)) == v"2.3.1"
+VersionNumber(2, 3, 1) == VersionNumber(Int8(2), UInt32(3), Int32(1)) == v"2.3.1"
 @test v"2.3.0" < v"2.3.1" < v"2.4.8" < v"3.7.2"
 
 #lowerbound and upperbound
@@ -200,20 +208,25 @@ import Base.check_new_version
 @test_throws ErrorException check_new_version([v"1", v"2"], v"2")
 @test check_new_version(VersionNumber[], v"0") == nothing
 @test check_new_version(VersionNumber[], v"0.0.1") == nothing
-@test_throws MethodError check_new_version(VersionNumber,[], v"0.0.2")
+@test_throws ErrorException check_new_version(VersionNumber[], v"0.0.2")
 @test check_new_version(VersionNumber[], v"0.1") == nothing
-@test_throws MethodError check_new_version(VersionNumber, [], v"0.2")
+@test_throws ErrorException check_new_version(VersionNumber[], v"0.2")
 @test check_new_version(VersionNumber[], v"1") == nothing
-@test_throws MethodError check_new_version(VersionNumber, [], v"2")
+@test_throws ErrorException check_new_version(VersionNumber[], v"2")
 @test_throws ErrorException check_new_version(VersionNumber[v"1", v"2", v"3"], v"2")
 @test_throws ErrorException check_new_version([v"1", v"2"], v"4")
 @test_throws ErrorException check_new_version([v"1", v"2"], v"2-rc")
+@test check_new_version([v"1", v"2"], v"2.0.1") == nothing
+@test check_new_version([v"1", v"2"], v"2.1") == nothing
+@test check_new_version([v"1", v"2"], v"3") == nothing
 
 # banner
 import Base.banner
-@test banner() == nothing
+io = IOBuffer()
+@test banner(io) == nothing
+@test length(takebuf_string(io)) > 50
 
 # julia_version.h version test
-@test VERSION.major == ccall(:jl_ver_major,Cint,())
-@test VERSION.minor == ccall(:jl_ver_minor,Cint,())
-@test VERSION.patch == ccall(:jl_ver_patch,Cint,())
+@test VERSION.major == ccall(:jl_ver_major, Cint, ())
+@test VERSION.minor == ccall(:jl_ver_minor, Cint, ())
+@test VERSION.patch == ccall(:jl_ver_patch, Cint, ())