Skip to content

Commit

Permalink
Keep llvm from rebuilding uncoditionally
Browse files Browse the repository at this point in the history
  • Loading branch information
Keno committed May 28, 2012
1 parent d948729 commit 623bc39
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deps/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,12 @@ llvm_python_workaround:
mkdir -p llvm-$(LLVM_VER)/python2_path && \
ln -s /usr/bin/python2 "llvm-$(LLVM_VER)/python2_path/python"

$(LLVM_OBJ_SOURCE): llvm-$(LLVM_VER)/configure llvm_python_workaround
$(LLVM_OBJ_SOURCE): llvm-$(LLVM_VER)/configure | llvm_python_workaround
cd llvm-$(LLVM_VER) && \
export PATH=$(abspath llvm-$(LLVM_VER)/python2_path):$$PATH && \
./configure --prefix=$(abspath $(USR)) --disable-threads --enable-optimized --disable-profiling --disable-assertions --enable-shared --enable-targets=x86,x86_64 --disable-bindings --disable-docs CC=$(GCC) CXX=$(GPLUSPLUS) && \
$(MAKE)
$(LLVM_OBJ_TARGET): $(LLVM_OBJ_SOURCE) llvm_python_workaround
$(LLVM_OBJ_TARGET): $(LLVM_OBJ_SOURCE) | llvm_python_workaround
export PATH=$(abspath llvm-$(LLVM_VER)/python2_path):$$PATH && \
$(MAKE) -C llvm-$(LLVM_VER) install
$(INSTALL_NAME_CMD) libLLVM-$(LLVM_VER).$(SHLIB_EXT) $(USRLIB)/libLLVM-$(LLVM_VER).$(SHLIB_EXT)
Expand Down

3 comments on commit 623bc39

@StefanKarpinski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah. What does the pipe do in a make rule like that?

@Keno
Copy link
Member Author

@Keno Keno commented on 623bc39 May 28, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It keeps make from marking the target outdated. See http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types

@StefanKarpinski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That had not occurred to us, dude.

Please sign in to comment.