Fix broadcast with RowVectors of matrices

Fix #20979. Amusingly, this bug is a direct of `transpose` being recursive.
JuliaLang · Mar 10, 2017 · 8284aff · 8284aff
1 parent 0e970f0
commit 8284aff
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/base/linalg/rowvector.jl b/base/linalg/rowvector.jl
@@ -144,12 +144,12 @@ end
 @inline to_vec(x::Number) = x
 @inline to_vecs(rowvecs...) = (map(to_vec, rowvecs)...)
 
-# map
-@inline map(f, rowvecs::RowVector...) = RowVector(map(f, to_vecs(rowvecs...)...))
+# map: Preserve the RowVector, but note that `f` expects transposed elements
+@inline map(f, rowvecs::RowVector...) = RowVector(map(transpose∘f∘transpose, to_vecs(rowvecs...)...))
 
 # broacast (other combinations default to higher-dimensional array)
 @inline broadcast(f, rowvecs::Union{Number,RowVector}...) =
-    RowVector(broadcast(f, to_vecs(rowvecs...)...))
+    RowVector(broadcast(transpose∘f∘transpose, to_vecs(rowvecs...)...))
 
 # Horizontal concatenation #
 

diff --git a/test/linalg/rowvector.jl b/test/linalg/rowvector.jl
@@ -249,3 +249,13 @@ end
         @test A'*x' == A'*y == B*x' == B*y == C'
     end
 end
+
+@testset "issue #20979" begin
+    f20979(z::Complex) = [z.re -z.im; z.im z.re]
+    v = [1+2im]'
+    @test (f20979.(v))[1] == f20979(v[1])
+    @test f20979.(v) == f20979.(collect(v))
+
+    w = rand(Complex128, 3)
+    @test f20979.(v') == f20979.(collect(v')) == (f20979.(v))'
+end