Skip to content

Commit

Permalink
Fix ambiguity test failure when arrayops and LinearAlgebra run on the…
Browse files Browse the repository at this point in the history
… same worker (#28836)
  • Loading branch information
mbauman authored and Keno committed Aug 23, 2018
1 parent 293c904 commit d55b044
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/arrayops.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2455,13 +2455,13 @@ end

# Ensure we can hash strange custom structs — and they hash the same in arrays
struct totally_not_five26034 end
Base.isequal(::totally_not_five26034, x)=isequal(5,x);
Base.isequal(x, ::totally_not_five26034)=isequal(5,x);
Base.isequal(::totally_not_five26034, x::Number)=isequal(5,x);
Base.isequal(x::Number, ::totally_not_five26034)=isequal(5,x);
Base.isequal(::totally_not_five26034, ::totally_not_five26034)=true;
Base.hash(::totally_not_five26034, h::UInt)=hash(5, h);
import Base.==
==(::totally_not_five26034, x)= (5==x);
==(x,::totally_not_five26034)= (5==x);
==(::totally_not_five26034, x::Number)= (5==x);
==(x::Number,::totally_not_five26034)= (5==x);
==(::totally_not_five26034,::totally_not_five26034)=true;
@testset "issue #26034" begin
n5 = totally_not_five26034()
Expand Down

2 comments on commit d55b044

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`make -j3 USECCACHE=1`, ProcessExited(2)) [2]

Logs and partial data can be found here
cc @ararslan

Please sign in to comment.