Skip to content

Commit

Permalink
add a base keyword to logspace (#22310)
Browse files Browse the repository at this point in the history
to specify the base (which otherwise defaults to 10)
  • Loading branch information
fredrikekre authored and quinnj committed Jun 19, 2017
1 parent 7d57d26 commit d7aa63c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 3 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Expand Up @@ -65,6 +65,9 @@ Library improvements
git repo. Additionally, the argument order was changed to be consistent with the git
command line tool ([#22062]).

* `logspace` now accepts a `base` keyword argument to specify the base of the logarithmic
range. The base defaults to 10 ([#22310]).

Compiler/Runtime improvements
-----------------------------

Expand Down
14 changes: 11 additions & 3 deletions base/range.jl
Expand Up @@ -316,9 +316,9 @@ function print_range(io::IO, r::Range,
end

"""
logspace(start::Real, stop::Real, n::Integer=50)
logspace(start::Real, stop::Real, n::Integer=50; base=10)
Construct a vector of `n` logarithmically spaced numbers from `10^start` to `10^stop`.
Construct a vector of `n` logarithmically spaced numbers from `base^start` to `base^stop`.
```jldoctest
julia> logspace(1.,10.,5)
Expand All @@ -328,9 +328,17 @@ julia> logspace(1.,10.,5)
3.16228e5
5.62341e7
1.0e10
julia> logspace(1.,10.,5,base=2)
5-element Array{Float64,1}:
2.0
9.51366
45.2548
215.269
1024.0
```
"""
logspace(start::Real, stop::Real, n::Integer=50) = 10.^linspace(start, stop, n)
logspace(start::Real, stop::Real, n::Integer=50; base=10) = base.^linspace(start, stop, n)

## interface implementations

Expand Down
11 changes: 11 additions & 0 deletions test/ranges.jl
Expand Up @@ -918,3 +918,14 @@ let linsp = linspace(1.0, 2.0, 10)
@test Float32(linsp.ref) === convert(Float32, linsp.ref)
@test Float32(linsp.ref) linsp.ref.hi + linsp.ref.lo
end

@testset "logspace" begin
n = 10; a = 2; b = 4
# test default values; n = 50, base = 10
@test logspace(a, b) == logspace(a, b, 50) == 10.^linspace(a, b, 50)
@test logspace(a, b, n) == 10.^linspace(a, b, n)
for base in (10, 2, e)
@test logspace(a, b, base=base) == logspace(a, b, 50, base=base) == base.^linspace(a, b, 50)
@test logspace(a, b, n, base=base) == base.^linspace(a, b, n)
end
end

0 comments on commit d7aa63c

Please sign in to comment.