News and compat for #28790 copyto!(::AbstractMatrix, ::UniformScaling)

JuliaLang · Dec 1, 2018 · e63f465 · e63f465
1 parent 219f277
commit e63f465
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -77,6 +77,7 @@ Standard library changes
   * New `sort!(::AbstractArray; dims)` method that can sort the array along the `dims` dimension ([#28902]).
   * `range` now accept `stop` as a positional argument ([#28708]).
   * `parse(Bool, str)` is now supported ([#29997]).
+  * `copyto!(::AbstractMatrix, ::UniformScaling)` supports rectangular matrices now ([#28790]).
 
 Compiler/Runtime improvements
 -----------------------------

diff --git a/stdlib/LinearAlgebra/src/uniformscaling.jl b/stdlib/LinearAlgebra/src/uniformscaling.jl
@@ -212,6 +212,15 @@ function isapprox(J::UniformScaling, A::AbstractMatrix;
 end
 isapprox(A::AbstractMatrix, J::UniformScaling; kwargs...) = isapprox(J, A; kwargs...)
 
+"""
+    copyto!(dest::AbstractMatrix, src::UniformScaling)
+
+Copies a [`UniformScaling`](@ref) onto a matrix.
+
+!!! compat "Julia 1.1"
+    In Julia 1.0 this method only supported a square destination matrix. Julia 1.1. added
+    support for a rectangular matrix.
+"""
 function copyto!(A::AbstractMatrix, J::UniformScaling)
     @assert !has_offset_axes(A)
     fill!(A, 0)