rename null to nullspace

JuliaLang · Jan 10, 2015 · eac0249 · eac0249 · StefanKarpinski · Jan 10, 2015
1 parent 24b14c6
commit eac0249
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -268,3 +268,5 @@ const base64 = base64encode
 @deprecate beginswith startswith
 
 @deprecate functionlocs(f,t)  map(functionloc, methods(f,t))
+
+@deprecate null nullspace
diff --git a/base/exports.jl b/base/exports.jl
@@ -676,7 +676,7 @@ export
     lufact,
     lyap,
     norm,
-    null,
+    nullspace,
     ordschur!,
     ordschur,
     peakflops,

diff --git a/base/linalg/dense.jl b/base/linalg/dense.jl
@@ -455,14 +455,14 @@ pinv(a::StridedVector) = pinv(reshape(a, length(a), 1))
 pinv(x::Number) = isfinite(one(x)/x) ? one(x)/x : zero(x)
 
 ## Basis for null space
-function null{T}(A::StridedMatrix{T})
+function nullspace{T}(A::StridedMatrix{T})
     m, n = size(A)
     (m == 0 || n == 0) && return eye(T, n)
     SVD = svdfact(A, thin=false)
     indstart = sum(SVD[:S] .> max(m,n)*maximum(SVD[:S])*eps(eltype(SVD[:S]))) + 1
     return SVD[:V][:,indstart:end]
 end
-null(a::StridedVector) = null(reshape(a, length(a), 1))
+nullspace(a::StridedVector) = nullspace(reshape(a, length(a), 1))
 
 function cond(A::StridedMatrix, p::Real=2)
     if p == 2

diff --git a/test/linalg1.jl b/test/linalg1.jl
@@ -229,13 +229,13 @@ debug && println("Solve square general system of equations")
     @test_throws DimensionMismatch b\b'
     @test norm(a*x - b, 1)/norm(b) < ε*κ*n*2 # Ad hoc, revisit!
 
-debug && println("Test null")
+debug && println("Test nullspace")
     if eltya != BigFloat && eltyb != BigFloat # Revisit when implemented in julia
-        a15null = null(a[:,1:5]')
+        a15null = nullspace(a[:,1:5]')
         @test rank([a[:,1:5] a15null]) == 10
         @test_approx_eq_eps norm(a[:,1:5]'a15null, Inf) zero(eltya) 300ε
         @test_approx_eq_eps norm(a15null'a[:,1:5], Inf) zero(eltya) 400ε
-        @test size(null(b), 2) == 0
+        @test size(nullspace(b), 2) == 0
     end
 
     end # for eltyb