try the ordered Dict representation mentioned in #10092

JuliaLang · May 29, 2015 · ecf5033 · ecf5033
1 parent 6b4c275
commit ecf5033
Show file tree

Hide file tree

Showing 5 changed files with 140 additions and 135 deletions.
diff --git a/base/array.jl b/base/array.jl
@@ -1458,15 +1458,11 @@ end
 function setdiff(a, b)
     args_type = promote_type(eltype(a), eltype(b))
     bset = Set(b)
-    ret = Array(args_type,0)
-    seen = Set{eltype(a)}()
+    seen = Set{args_type}()
     for a_elem in a
-        if !in(a_elem, seen) && !in(a_elem, bset)
-            push!(ret, a_elem)
-            push!(seen, a_elem)
-        end
+        !in(a_elem, bset) && push!(seen, a_elem)
     end
-    ret
+    collect(seen)
 end
 # symdiff is associative, so a relatively clean
 # way to implement this is by using setdiff and union, and