move ConsoleLogger into Base

JuliaLang · May 10, 2024 · f24c773 · f24c773
1 parent 28321e3
commit f24c773
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/base/Base.jl b/base/Base.jl
@@ -402,13 +402,13 @@ include("weakkeydict.jl")
 include("scopedvalues.jl")
 using .ScopedValues
 
-# Logging
-include("logging.jl")
-using .CoreLogging
-
 # metaprogramming
 include("meta.jl")
 
+# Logging
+include("logging/logging.jl")
+using .CoreLogging
+
 include("env.jl")
 
 # functions defined in Random
@@ -634,6 +634,8 @@ function __init__()
     if get_bool_env("JULIA_USE_FLISP_PARSER", false) === false
         JuliaSyntax.enable_in_core!()
     end
+
+    CoreLogging.global_logger(CoreLogging.ConsoleLogger())
     nothing
 end
 

diff --git a/stdlib/Logging/src/ConsoleLogger.jl → base/logging/ConsoleLogger.jl b/stdlib/Logging/src/ConsoleLogger.jl → base/logging/ConsoleLogger.jl
diff --git a/base/logging.jl → base/logging/logging.jl b/base/logging.jl → base/logging/logging.jl
@@ -700,4 +700,6 @@ end
 
 _global_logstate = LogState(SimpleLogger())
 
+include("logging/ConsoleLogger.jl")
+
 end # CoreLogging
diff --git a/base/meta.jl b/base/meta.jl
@@ -5,8 +5,6 @@ Convenience functions for metaprogramming.
 """
 module Meta
 
-using ..CoreLogging
-
 export quot,
        isexpr,
        isidentifier,

diff --git a/stdlib/Logging/src/Logging.jl b/stdlib/Logging/src/Logging.jl
@@ -68,7 +68,7 @@ Alias for [`LogLevel(1_000_001)`](@ref LogLevel).
 const AboveMaxLevel = Base.CoreLogging.AboveMaxLevel
 
 using Base.CoreLogging:
-    closed_stream
+    closed_stream, ConsoleLogger, default_metafmt
 
 export
     AbstractLogger,
@@ -92,8 +92,6 @@ export
     Error,
     AboveMaxLevel
 
-include("ConsoleLogger.jl")
-
 # The following are also part of the public API, but not exported:
 #
 # 1. Log levels:
@@ -102,8 +100,4 @@ include("ConsoleLogger.jl")
 # 2. AbstractLogger message related functions:
 #  handle_message, shouldlog, min_enabled_level, catch_exceptions,
 
-function __init__()
-    global_logger(ConsoleLogger())
-end
-
 end