make Vector{UInt8}(::String) copy as documented.

closes #24388
JuliaLang · Dec 6, 2018 · f72ee3c · f72ee3c
1 parent 1c05d0c
commit f72ee3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/base/strings/string.jl b/base/strings/string.jl
@@ -71,6 +71,8 @@ String(s::Symbol) = unsafe_string(unsafe_convert(Ptr{UInt8}, s))
 unsafe_wrap(::Type{Vector{UInt8}}, s::String) = ccall(:jl_string_to_array, Ref{Vector{UInt8}}, (Any,), s)
 
 (::Type{Vector{UInt8}})(s::CodeUnits{UInt8,String}) = copyto!(Vector{UInt8}(undef, length(s)), s)
+(::Type{Vector{UInt8}})(s::String) = Vector{UInt8}(codeunits(s))
+(::Type{Array{UInt8}})(s::String)  = Vector{UInt8}(codeunits(s))
 
 String(s::CodeUnits{UInt8,String}) = s.s
 

diff --git a/test/strings/basic.jl b/test/strings/basic.jl
@@ -926,6 +926,10 @@ let v = unsafe_wrap(Vector{UInt8}, "abc")
     @test_throws BoundsError v[1]
     push!(v, UInt8('x'))
     @test s == "abc"
+    s = "abc"
+    v = Vector{UInt8}(s)
+    v[1] = 0x40
+    @test s == "abc"
 end
 
 # PR #25535