Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove separate _mstr macro feature? #10228

Closed
JeffBezanson opened this issue Feb 17, 2015 · 3 comments
Closed

remove separate _mstr macro feature? #10228

JeffBezanson opened this issue Feb 17, 2015 · 3 comments
Labels
kind:breaking This change will break code needs decision A decision on this change is needed parser Language parsing and surface syntax
Milestone
0.4.x

Comments

@JeffBezanson
Copy link
Sponsor Member

There are now several _str macros with corresponding _mstr versions, which are identical except that they call Base.triplequoted first. I think this equivalence should be built in: for triple quoted strings, do the unindenting, then call the plain _str macro.

Needing to write two identical versions of every string macro is annoying. Even worse, the two versions might be utterly different, including not doing the expected unindenting, which seems to be a mere obfuscation-enabler.
@JeffBezanson JeffBezanson added needs decision A decision on this change is needed kind:breaking This change will break code parser Language parsing and surface syntax labels Feb 17, 2015
@ivarne
Copy link
Sponsor Member

ivarne commented Feb 17, 2015

+:100: I've been meaning to suggest this for a long time, but wanted to understand the reasoning behind the current behaviour first.

@StefanKarpinski
Copy link
Sponsor Member

Yes.

@stevengj
Copy link
Member

+1

@JeffBezanson JeffBezanson added this to the 0.4 milestone Feb 19, 2015
@garrison garrison mentioned this issue Apr 11, 2015
Closed
pao added a commit to JuliaLang/JuliaDoc that referenced this issue May 8, 2015
@pao
Fix for new lowering of triple-quote string macros
012be05 
The _mstr macros are no longer used, and dispatch to the _str macro
instead. JuliaLang/julia#10228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:breaking This change will break code needs decision A decision on this change is needed parser Language parsing and surface syntax
Projects
None yet
Milestone
0.4.x
Development

No branches or pull requests
4 participants
@ivarne @StefanKarpinski @JeffBezanson @stevengj