Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move printing of "unhandled task errors" to a finalizer #12403

Closed
amitmurthy opened this issue Jul 31, 2015 · 3 comments
Closed

Move printing of "unhandled task errors" to a finalizer #12403

amitmurthy opened this issue Jul 31, 2015 · 3 comments
Assignees
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects. domain:error handling Handling of exceptions by Julia or the user

Comments

@amitmurthy
Copy link
Contributor

Once a task has been waited upon, or its results fetched, it should be marked as handled even if there were no waiters at the time of task exit.

I'll submit a PR for this. Just adding it here so it doesn't get missed.

@amitmurthy amitmurthy self-assigned this Jul 31, 2015
@JeffBezanson
Copy link
Sponsor Member

This might be better than the current situation, but my worry is that people who dislike the error will still be annoyed by it, and people who want the error will be upset that it depends on GC timing. The GC might not decide to collect a task until half an hour later.

@amitmurthy
Copy link
Contributor Author

There are two separate issues here:

  1. Printing of "unhandled task errors" - this can (possibly) be controlled by an environment variable.
  2. The more important one is detecting when a task in error is unhandled. In the current model, if there are no waiters on a task at the time of failure it is deemed unhandled, irrespective of the fact that the task reference may still be held elsewhere and a wait called on it in the future.

@kshyatt kshyatt added domain:display and printing Aesthetics and correctness of printed representations of objects. domain:error handling Handling of exceptions by Julia or the user labels Jan 25, 2017
@vtjnash
Copy link
Sponsor Member

vtjnash commented Apr 26, 2021

Closed by #39518

@vtjnash vtjnash closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects. domain:error handling Handling of exceptions by Julia or the user
Projects
None yet
Development

No branches or pull requests

4 participants