RFC: Add detach(::Task) method to monitor for Task failures #39518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Feb 4, 2021
|
Big 👍 Only question is the name --- on triage we discussed using something like |
This adds a convenience method to be able to essentially wrap an arbitrary task in a try/catch/log block conveniently.
vtjnash
force-pushed
the
jn/detached-Task
branch
from
709eae5
to
d1d37f7
Compare
vtjnash
added
status:merge me
|
You guys went with |
|
It is not too late to rename, we've still got time until we branch. But as they say, the best way to get review is to merge :P |
|
What about adding a keyword argument to the |
simeonschaub
removed
the
status:merge me
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a common problem where some background Task might fail, and we want to know about it. There might be additional opportunities to also restart it and such, but just logging seems to be the most common desire throughout the code (for debugging).