Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cor, cov: remove mean keyword arg #13081

Closed
StefanKarpinski opened this issue Sep 11, 2015 · 4 comments · Fixed by #13465
Closed

cor, cov: remove mean keyword arg #13081

StefanKarpinski opened this issue Sep 11, 2015 · 4 comments · Fixed by #13465
Labels
kind:breaking This change will break code
Milestone
0.5.0

Comments

@StefanKarpinski
Copy link
Sponsor Member

https://groups.google.com/forum/#!topic/julia-users/KHfhB-VOVdU
@StefanKarpinski StefanKarpinski added the kind:breaking This change will break code label Sep 11, 2015
@StefanKarpinski StefanKarpinski added this to the 0.5.0 milestone Sep 11, 2015
@johnmyleswhite
Copy link
Member

Sounds like a good idea

@simonster
Copy link
Member

Or we could just fix the type instability...

@nalimilan
Copy link
Member

I'm not against removing these arguments, but we need this pattern of special default values to work in many cases. There have been discussions about using Nullable, and automatically converting keyword arguments to their expected type (#7357 (comment), #10561 (comment)).

andreasnoack added a commit that referenced this issue Oct 6, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
48b5955 
This fixes #13081 and the type instability that motivated that issue.
andreasnoack added a commit that referenced this issue Oct 6, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
e795633 
This fixes #13081 and the type instability that motivated that issue.
@andreasnoack andreasnoack mentioned this issue Oct 6, 2015
Merged
andreasnoack added a commit that referenced this issue Oct 6, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
06933c3 
This fixes #13081 and the type instability that motivated that issue.
andreasnoack added a commit that referenced this issue Oct 7, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
9d9547a 
This fixes #13081 and the type instability that motivated that issue.
andreasnoack added a commit that referenced this issue Oct 7, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
de8e6c1 
This fixes #13081 and the type instability that motivated that issue.
andreasnoack added a commit that referenced this issue Oct 8, 2015
@andreasnoack
Make cov and cor similar to mean and var by removing keyword arguments.
c661ef6 
This fixes #13081 and the type instability that motivated that issue.
@mdcfrancis
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:breaking This change will break code
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Make cov and cor similar to mean and var by removing keyword arguments. JuliaLang/julia
5 participants
@johnmyleswhite @StefanKarpinski @simonster @nalimilan @mdcfrancis