Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate StackTraces.jl into Base #14212

Closed
spurll opened this issue Dec 1, 2015 · 8 comments
Closed

Integrate StackTraces.jl into Base #14212

spurll opened this issue Dec 1, 2015 · 8 comments

Comments

@spurll
Copy link
Contributor

spurll commented Dec 1, 2015

A few people in the community have been looking for stacktrace/backtrace functionality that is easier to use programmatically than what is currently provided by Base.backtrace. StackTraces.jl provides an immutable StackFrame type that simplifies interacting with a stack trace. (It can be used to add stack trace information when logging with Lumberjack.jl for example.)

@jakebolewski and @iamed2 have recommended that this package be included in Base.

@JeffBezanson
Copy link
Sponsor Member

+1

This functionality is very reasonable and compact, and might even simplify things in Base.

@ihnorton
Copy link
Member

ihnorton commented Dec 1, 2015

👍 Though would be good to unify/refactor with the functions and data structures in Profile so that we don't have two names for a number of nearly-identical things. (e.g. LineInfo)

@tkelman
Copy link
Contributor

tkelman commented Dec 1, 2015

Agreed, there's some overlap with profile. This kind of thing will be really useful for tooling, debugger interfaces etc so may as well agree on a data structure for it.

@StefanKarpinski
Copy link
Sponsor Member

+1 – @spurll, do you want to make a PR?

@spurll
Copy link
Contributor Author

spurll commented Dec 1, 2015

Will do. I'm heading out for the night, but barring catastrophe I'll do it first thing tomorrow. Thanks for the feedback, folks!

@spurll
Copy link
Contributor Author

spurll commented Dec 11, 2015

Wow, this took longer than I expected. I've done some refactoring to address redundancies with Profile. I plan to issue the pull request on Monday.

@spurll
Copy link
Contributor Author

spurll commented Dec 22, 2015

PR is submitted: #14469

@yuyichao
Copy link
Contributor

Closed by #14815 ?

@vtjnash vtjnash closed this as completed Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants