track the exact lambda associated with a fptr #14815

vtjnash · 2016-01-27T18:38:41Z

this allows printing the actual method signature of the function in the call stack

both profiling and backtrace printing have been extended to show this
full linfo signature (when available)

for example:

julia> error(1,'2',"3")
ERROR: 123
 in error(Int64, Char, Vararg{Any}) at error.jl:22
 in eval(Module, Any) at ./boot.jl:265

yuyichao · 2016-01-27T18:48:45Z

Does this work for sysimg frames?

vtjnash · 2016-01-27T19:00:52Z

yes, that is covered too

yuyichao · 2016-01-27T19:07:55Z

Awesome! Can't wait for the combination of this and #14799 or #12380.

Is this stored in the debug info and can it be loaded by gdb too?

vtjnash · 2016-01-27T19:18:37Z

right now it's still just stored in the sysimg -- i'll eventually add a gdb accessor (and get jl_gdblookup to print this extra info too)

tkelman · 2016-01-29T05:45:42Z

test/stacktraces.jl

+
+# Some tests don't currently work for Appveyor 32-bit Windows
+const APPVEYOR_WIN32 = (
+    OS_NAME == :Windows && WORD_SIZE == 32 && get(ENV, "APPVEYOR", "False") == "True"


is this still the case after your fixes @vtjnash?

Passes locally on win32. Try deleting?

edit: I take that back, partially. make testall passes but make testall1 fails...

that sounds odd. i may need to power on my windows machine to see what's up with backtraces now

If you can't figure this out, please do not merge this with the appveyor special-casing. If it fails on win32 and we don't know how to fix it yet, skip it all the time on win32, not just on appveyor. Tests that fail locally but not on CI is no good.

i think it should be fixed now by 9ce59c8#diff-d4b80bf89e46982070f234dd7cc344a9L1107

the wrong return value there (from a post-v0.4 code reorganization) sometimes causes backtraces to become truncated / corrupted

looks like it. Nice work!

d'oh... it may have fixed win32, but locally win64 still had a failure in make testall1

* stacktraces Test Failed Expression: catch_backtrace() == StackFrame[] Evaluated: [Ptr{Void} @0x000000006d0b869e,Ptr{Void} @0x000000006d0b9680,Ptr{Void} @0x00000002a30eec45,Ptr{Void} @0x00000002a30eed24,Ptr{Void} @0x000000006d0c7eec,Ptr{Void} @0x000000006d09f34a,Ptr{Void} @0x000000006d0c885d,Ptr{Void} @0x000000001b43b00f,Ptr{Void} @0x000000001b43b037,Ptr{Void} @0x000000006d093697,Ptr{Void} @0x000000001b41f749,Ptr{Void} @0x000000001b41f9c7,Ptr{Void} @0x000000006d093697,Ptr{Void} @0x0000000020298f88,Ptr{Void} @0x0000000020299972,Ptr{Void} @0x0000000020299a2e,Ptr{Void} @0x000000006d093697,Ptr{Void} @0x00000000202720b9,Ptr{Void} @0x000000006d093697,Ptr{Void} @0x000000006d0a6d1a,Ptr{Void} @0x000000002026f0be,Ptr{Void} @0x000000006d093697,Ptr{Void} @0x0000000020270cdc,Ptr{Void} @0x0000000020271944,Ptr{Void} @0x000000006d09374f,Ptr{Void} @0x000000006d0b9891] == StackFrame[] ERROR: LoadError: LoadError: There was an error during testing in record(Base.Test.#record, Base.Test.FallbackTestSet, Base.Test.Fail) at .\test.jl:317 in do_test(Base.Test.#do_test, Base.Test.Returned, Expr) at .\test.jl:215 in include(Core.#include, UTF8String) at .\boot.jl:264 in include_from_node1(Base.#include_from_node1, ASCIIString) at .\loading.jl:417 [inlined code] from .\util.jl:179 in runtests(#runtests, ASCIIString) at C:\cygwin64\home\Tony\julia\test\testdefs.jl:7 in run_work_thunk(Base.#run_work_thunk, Base.##247#248{##16#24,Tuple{ASCIIString}}, Bool) at .\multi.jl:714 in remotecall_fetch(Base.#remotecall_fetch, Any, LocalProcess, ASCIIString, Vararg{ASCIIString}) at .\multi.jl:787 in remotecall_fetch(Base.#remotecall_fetch, Any, Int64, ASCIIString, Vararg{ASCIIString}) at .\multi.jl:803 [inlined code] from C:\cygwin64\home\Tony\julia\test\runtests.jl:36 in #15(##15#23{Array{ASCIIString,1}}) at .\task.jl:431 while loading C:\cygwin64\home\Tony\julia\test\stacktraces.jl, in expression starting on line 45 in remotecall_fetch(Base.#remotecall_fetch, Any, LocalProcess, ASCIIString, Vararg{ASCIIString}) at .\multi.jl:788 in remotecall_fetch(Base.#remotecall_fetch, Any, Int64, ASCIIString, Vararg{ASCIIString}) at .\multi.jl:803 [inlined code] from C:\cygwin64\home\Tony\julia\test\runtests.jl:36 in #15(##15#23{Array{ASCIIString,1}}) at .\task.jl:431 in sync_end(Base.#sync_end) at .\task.jl:397 [inlined code] from .\task.jl:406 in #11(##11#19) at C:\cygwin64\home\Tony\julia\test\runtests.jl:31 in cd(Base.Filesystem.#cd, ##11#19, ASCIIString) at .\file.jl:57 in include(Core.#include, ASCIIString) at .\boot.jl:264 in include_from_node1(Base.#include_from_node1, UTF8String) at .\loading.jl:417 in process_options(Base.#process_options, Base.JLOptions) at .\client.jl:244 in _start(Base.#_start) at .\client.jl:300 while loading C:\cygwin64\home\Tony\julia\test\runtests.jl, in expression starting on line 13

oh, right. that test needs to be fixed to work with make testall1. i'll work on submitting a patch

edit: 8702da3

this allows printing the actual method signature of the function in the call stack both profiling and backtrace printing have been extended to show this full linfo signature (when available)

Tests and documentation for stacktraces. Updated NEWS.md with stacktraces functionality. Refactored, doctests, show_stacktrace is now show. Added doctests to the manual. Removed show_stacktrace in favour of show(x::StackFrame). Removed format_stacktrace and format_stackframe. Additional test cases (which currently fail due to difficult to track down line number issues) Test for invalid frame. Removed failing Win32 test. Reintroduced UNKNOWN constant stack frame from profile.jl. Added test case for looking up an invalid stack frame. Selectively removed some tests that consistently fail in Appveyor's 32-bit Windows LVM.

Keno · 2016-01-30T21:26:18Z

Great! I had a hacky version of this locally. I'll update my code to use this version instead.

track the exact lambda associated with a fptr

Keno · 2016-01-31T15:44:33Z

While you're on this track, I think one thing that would be super useful to do is to fix the way we handle inlined functions. The DWARF we generate right now is highly incorrect, and the AST representation is probably not much better. It would also be good to have a map of which functions a given function was inlined into, such that setting a breakpoint actually works (that's the one major case that won't work on my new iteration of Gallium - correctly breaking if a function was inlined).

vtjnash · 2016-01-31T18:30:57Z

Does the map need IR range coverage, or will it be sufficient (at least for now) if I just add a link to the right lambda static data?

Keno · 2016-01-31T18:32:20Z

For now, as long as I can ask, "get me all the lambda infos into which this function was inlined" (and can go to an fptr from there), that would be most amazing!

tkelman · 2016-02-07T19:22:27Z

base/replutil.jl

-                print(io,"\n$(code[1]) will only return a complex result if called with a complex argument. Try $(code[1])(complex(x)).")
-            elseif (code[1] == :^ && code[2] == symbol("intfuncs.jl")) || code[1] == :power_by_squaring #3024
+        code = StackTraces.lookup(b)
+        if code !== lookup && code.from_c


should this be StackTraces.lookup? the error message from sqrt(-1) is currently broken by this, evidently needs a test

vtjnash force-pushed the jn/debug branch 2 times, most recently from 412a986 to a0b517b Compare January 28, 2016 22:59

vtjnash mentioned this pull request Jan 28, 2016

Integrate StackTraces.jl into Base #14469

Closed

vtjnash force-pushed the jn/debug branch from a0b517b to 1b5204e Compare January 29, 2016 05:40

tkelman reviewed Jan 29, 2016
View reviewed changes

vtjnash force-pushed the jn/debug branch 5 times, most recently from 346c230 to 0d7d141 Compare January 30, 2016 06:48

vtjnash and others added 2 commits January 30, 2016 15:25

track the exact lambda associated with a fptr

9ce59c8

this allows printing the actual method signature of the function in the call stack both profiling and backtrace printing have been extended to show this full linfo signature (when available)

vtjnash force-pushed the jn/debug branch 2 times, most recently from 6864bc3 to d10854a Compare January 30, 2016 21:01

fix StackTraces and DRY some of the code

8a0a7d6

vtjnash force-pushed the jn/debug branch from d10854a to 8a0a7d6 Compare January 31, 2016 05:59

vtjnash added a commit that referenced this pull request Jan 31, 2016

Merge pull request #14815 from JuliaLang/jn/debug

278d128

track the exact lambda associated with a fptr

vtjnash merged commit 278d128 into master Jan 31, 2016

vtjnash deleted the jn/debug branch January 31, 2016 15:06

vtjnash mentioned this pull request Jan 31, 2016

track lambda static data dependents / inlined ASTs #14879

Closed

yuyichao mentioned this pull request Jan 31, 2016

Integrate StackTraces.jl into Base #14212

Closed

tkelman reviewed Feb 7, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

track the exact lambda associated with a fptr #14815

track the exact lambda associated with a fptr #14815

vtjnash commented Jan 27, 2016

yuyichao commented Jan 27, 2016

vtjnash commented Jan 27, 2016

yuyichao commented Jan 27, 2016

vtjnash commented Jan 27, 2016

tkelman Jan 29, 2016

tkelman Jan 29, 2016

vtjnash Jan 29, 2016

tkelman Jan 30, 2016

vtjnash Jan 30, 2016

tkelman Jan 30, 2016

tkelman Jan 31, 2016

vtjnash Jan 31, 2016

Keno commented Jan 30, 2016

Keno commented Jan 31, 2016

vtjnash commented Jan 31, 2016

Keno commented Jan 31, 2016

tkelman Feb 7, 2016

track the exact lambda associated with a fptr #14815

track the exact lambda associated with a fptr #14815

Conversation

vtjnash commented Jan 27, 2016

yuyichao commented Jan 27, 2016

vtjnash commented Jan 27, 2016

yuyichao commented Jan 27, 2016

vtjnash commented Jan 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Keno commented Jan 30, 2016

Keno commented Jan 31, 2016

vtjnash commented Jan 31, 2016

Keno commented Jan 31, 2016

Choose a reason for hiding this comment