-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed issym to issymmetric. #15192
Conversation
e600f73
to
6406504
Compare
Regarding the documentation then check out https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#improving-documentation. However, it can be a little confusing so feel free to ask. |
70a437e
to
201b62a
Compare
Thanks for the pointer. I hope I did it correctly, let's see if it builds on the CI-services. I could generate the docs locally without errors at least. I also |
b22a89b
to
5b0f497
Compare
I had missed an |
OSX Travis is not currently running all tests to avoid timing out. This looks good, thanks! I like |
Sounds like i could have benefitted from git grep. Cool, will use that next time. |
Are there others places to correct the change than the docs and |
Worth adding a note about the renaming to |
I've added a bullet. I chose |
eec25cf
to
57d6084
Compare
I force pushed the change, so unfortunately your message is gone, but I've moved it to the correct section. |
Sorry, I actually remember having read that you should do that when adding something to |
@pkofod Could you rebase this? |
@andreasnoack I will fix it later, but yes. I guess I just need to reorder and squash the commits, right? |
6bac7b0
to
7a3cc31
Compare
I hate and love git. Kind of messed the rebase up, but was able to go back, and it should be 👍 now |
What on earth did I do to make it build all the dependencies and fail? Did I err, or is it a travis thing? |
The Travis caching for dependencies was in a messed-up state, ref #15249, but it's fixed now - restarted. |
Thanks! |
Changed issym to issymmetric.
@pkofod Thanks. It would be great if you could also add an entry to |
JuliaLang/Compat.jl#175 for a similar PR to compat. |
Sure, I'll do it later! |
Fixes #15182 .
grepping
/julia/
tells me that there is anissym
variable in some.c
-files left, but they should obviously not be changed (they are boolean variables asking if a variable is a symbol by the way, so that strengthens the need for being precise).There is something I still need to do.
grep -r issym
still tells me (relevant)issym
's still live incontrib/BBEditTextWrangler-julia.plist
base/docs/helpdb/Base.jl
doc/stdlib/linalg.rst
I am unsure how the documentation system works in julia. Should I just change these files as well, or are some things auto-generated, and others are not - or? Thanks.
Edit: Obviously also need to deprecate
issym
, will do in the morning