Deprecate scale #15258
Merged
Deprecate scale #15258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +1,2 @@ | |||
| OPENBLAS_BRANCH=v0.2.15 | |||
| OPENBLAS_SHA1=53e849f4fcae4363a64576de00e982722c7304f9 | |||
| OPENBLAS_BRANCH=develop | |||
There was a problem hiding this comment.
don't hide this in an unrelated pr
andreasnoack
force-pushed
the
anj/scale
branch
from
0974b9e
to
a963258
Compare
|
|
||
| If ``A`` is a matrix and ``b`` is a vector, then ``scale(A,b)`` scales each column ``i`` of ``A`` by ``b[i]`` (similar to ``A*diagm(b)``\ ), while ``scale(b,A)`` scales each row ``i`` of ``A`` by ``b[i]`` (similar to ``diagm(b)*A``\ ), returning a new array. | ||
|
|
||
| Note: for large ``A``\ , ``scale`` can be much faster than ``A .* b`` or ``b .* A``\ , due to the use of BLAS. |
There was a problem hiding this comment.
so is this not true any more?
There was a problem hiding this comment.
The deprecation suggestion is to use Diagonal(b)*A which calls BLAS. Actually, the difference is not really because of BLAS, but broadcasting overhead. With a nested loop, the code vectorizes and is as fast as BLAS on my machine.
We could move the "Note" to an entry for *(Diagonal,Matrix) or broadcast, but I'm not sure it will be easy to find in any of those places.
andreasnoack
force-pushed
the
anj/scale
branch
from
a963258
to
63969cb
Compare
andreasnoack
force-pushed
the
anj/scale
branch
from
63969cb
to
dfbbedd
Compare
KristofferC
referenced
this pull request
Feb 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of
Diagonal(x)*Aorα*A.Fixes #12945.
Update: Note that the potential small slowdown of
Diagonal(x)*Ainstead ofscale(x,A)should be eliminated thanks to #15259.