Change default file creation mode to match Linux #16502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaLang#16466. Changes default file creation mode from u=rw, g=r, o=r to u=rw, g=rw, o=rw (Linux default). Note that with the default umask (0022), the resulting permissions do not change. It is only with a more permissive umask (e.g. 0000) that the resulting permissions would be different.
| @@ -892,7 +892,7 @@ ios_t *ios_file(ios_t *s, const char *fname, int rd, int wr, int create, int tru | |||
| fd = _wopen(fname_w, flags | O_BINARY | O_NOINHERIT, _S_IREAD | _S_IWRITE); | |||
| set_io_wait_begin(0); | |||
| #else | |||
| fd = open_cloexec(fname, flags, S_IRUSR | S_IWUSR /* 0600 */ | S_IRGRP | S_IROTH /* 0644 */); | |||
There was a problem hiding this comment.
LGTM. Maybe leave a short comment about umask here.
|
This needs to be added to NEWS for 0.5. |
|
Should we open a NEWS todo checklist issue? Closed issues/PRs on the milestone are a bit tough to track |
|
👍 Excellent idea. |
|
NEWS was added in 72f3a6b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #16466. Changes default file creation mode (for *nix) from u=rw, g=r, o=r to
u=rw, g=rw, o=rw (Linux default). Note that with the default umask
(0022), the resulting permissions do not change. It is only with a more
permissive umask (e.g. 0000) that the resulting permissions would be
different.