Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for I #18250

Closed
JaredCrean2 opened this issue Aug 26, 2016 · 10 comments
Closed

Docs for I #18250

JaredCrean2 opened this issue Aug 26, 2016 · 10 comments
Labels
domain:docs This change adds or pertains to documentation domain:linear algebra Linear algebra good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants needs docs Documentation for this change is required

Comments

@JaredCrean2
Copy link
Contributor

In #18247 , the I variable was mentioned, but (as far as I can see) there are no docs for it.

Just for clarification:

julia> a = rand(3,3)
3x3 Array{Float64,2}:
 0.125392   0.162639  0.0208102
 0.0438847  0.253112  0.817613 
 0.877253   0.27941   0.94262  

julia> I + a
3x3 Array{Float64,2}:
 1.12539    0.162639  0.0208102
 0.0438847  1.25311   0.817613 
 0.877253   0.27941   1.94262  
@JaredCrean2
Copy link
Contributor Author

Indeed, I did not see that. However, searching for Base.LinAlg.I returns no results, and the REPL help says that it is a UniformScaling of some kind, but not exactly what it is.

@jiahao jiahao added domain:docs This change adds or pertains to documentation domain:linear algebra Linear algebra labels Aug 26, 2016
@stevengj
Copy link
Member

help?> I
search: I IO if is Int in im Inf isa Int8 inv IPv6 IPv4 Int64 Int32 Int16 info imag ifft idct Inf64 Inf32 Inf16 Int128 issym isqrt isodd isnan isinf isdir irfft

  I

  An object of type UniformScaling, representing an identity matrix of any size.

This is a bit too terse to be useful, though.

@kshyatt kshyatt added the needs docs Documentation for this change is required label Aug 26, 2016
@kshyatt
Copy link
Contributor

kshyatt commented Aug 26, 2016

@stevengj I agree! This would be a great first doc PR for someone who wants to make one.

@kshyatt kshyatt added the good first issue Indicates a good issue for first-time contributors to Julia label Aug 26, 2016
@sudk1896
Copy link

@kshyatt: I'd like to take a stab at this. What do I have to do here ? Thanks.

@kshyatt
Copy link
Contributor

kshyatt commented Sep 13, 2016

Hi @sudk1896! That's great to hear. My suggestion would be to go into the docs/stdlib/numbers.rst to see how we've documented other constants (e.g. pi and e). Following that template, you could add a docstring for I to docs/stdlib/linalg.rst and then build the docs, commit your changes, and open the PR. Let me know if you would like more detailed instructions!

@sudk1896
Copy link

sudk1896 commented Sep 13, 2016

@kshyatt: AFAIK, I have to edit the doc-strings in the source and not the .rst since the .rst are compiled automatically from the source. Also, which modules can I find the constants pi and e and I implemented in ? (I'm in the process of another doc-fix, learnt the whole workflow).
The docs don't include the links to the files that the functions are actually implemented in.
Also, Shouldn't the docs point to the .jl files that the functions are implemented in instead of the .rst files, since that is where the doc-strings are originally generated from ?
Most of the python repos that I contributed to, did this.
Thanks.

@stevengj
Copy link
Member

I (and its docstring) are in base/linalg/uniformscaling.jl (see #6472). Things like pi are in base/irrationals.jl.

@kshyatt kshyatt added the Hacktoberfest Good for Hacktoberfest participants label Oct 5, 2016
@vsartor
Copy link

vsartor commented Jan 29, 2017

Given that the commit 573467a already added some examples to the docstring (specifically here), is there still a need for more documentation or should this be closed?

@andreasnoack
Copy link
Member

I think it is fine now that the example has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation domain:linear algebra Linear algebra good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants needs docs Documentation for this change is required
Projects
None yet
Development

No branches or pull requests

8 participants