RFC: Set to Set conversions #18727
RFC: Set to Set conversions #18727
Conversation
|
Test failure on x86_64 appears unrelated, should I force push to trigger a re-run? |
|
Travis log backed-up here: https://gist.github.com/vchuravy/b3e833ed16d6f7bde9aa65c039b3a2dc |
| @@ -193,3 +193,6 @@ function hash(s::Set, h::UInt) | |||
| end | |||
| return h | |||
| end | |||
|
|
|||
| convert{T}(::Type{Set{T}}, s::Set{T}) = s | |||
| convert{T,S}(::Type{Set{T}}, x::Set{S}) = Set{T}(convert(T, e) for e in x) | |||
There was a problem hiding this comment.
I believe just Set{T}(x) would work.
There was a problem hiding this comment.
Thank you, I really should have realised that one on my own.
|
👍 Really surprising we didn't have this already! |
|
Improved version pushed. I also think I will submit a similar PR for |
| iset = Set([17, 4711]) | ||
| @test convert(Set{Float64}, iset) == iset | ||
| fset = Set([17.0, 4711.0]) | ||
| @test convert(Set{Int}, fset) == fset |
There was a problem hiding this comment.
test the element types of the result if possible
There was a problem hiding this comment.
In a hurry this morning, so I only dug through the manual briefly and pushed the cleanest (still dirty) way I could think of doing this. More julian suggestions are most welcome.
As a major set fan I found it somewhat odd that
convert(Vector{String}, split("foo bar baz qux"))works, but the same logic for sets,convert(Set{String}, Set(split("foo bar baz qux"))), doesn't. This is a patch based on my own little hack that I introduced in a module to get around the aforementioned issue. Feedback is as always most welcome.