Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL shell mode string interpolation regression #22176

Closed
samuelpowell opened this issue Jun 1, 2017 · 3 comments · Fixed by #22413
Closed

REPL shell mode string interpolation regression #22176

samuelpowell opened this issue Jun 1, 2017 · 3 comments · Fixed by #22413
Assignees
@StefanKarpinski
Labels
kind:regression Regression in behavior compared to a previous version stdlib:REPL Julia's REPL (Read Eval Print Loop)
Milestone
0.6.x

Comments

@samuelpowell
Copy link
Member

Originally reported on Discourse

On v0.5.1:

shell> echo $("hello world")
hello world

On v0.6.0-rc2.0:

shell> echo $("hello world")
$(hello world)

Version info:

Julia Version 0.6.0-rc2.0
Commit 68e911be53 (2017-05-18 02:31 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin13.4.0)
  CPU: Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, skylake)

cc @StefanKarpinski
@giordano
Copy link
Contributor

giordano commented Jun 1, 2017

Probably related: 0.5.1:

julia> str = "hello world"
"hello world"

shell> echo $str
hello world

Julia 0.7

julia> str = "hello world"
"hello world"

shell> echo $str
$str

@JeffBezanson JeffBezanson added kind:regression Regression in behavior compared to a previous version stdlib:REPL Julia's REPL (Read Eval Print Loop) labels Jun 1, 2017
@StefanKarpinski StefanKarpinski added this to the 0.6.x milestone Jun 1, 2017
@StefanKarpinski StefanKarpinski self-assigned this Jun 2, 2017
@tkelman
Copy link
Contributor

tkelman commented Jun 17, 2017

@StefanKarpinski did you get a chance to look at this?

@StefanKarpinski
Copy link
Sponsor Member

No, I guess I can take a look at it now so it can sneak into 0.6.0 if I fix it today.

StefanKarpinski added a commit that referenced this issue Jun 17, 2017
@StefanKarpinski
fix shell mode interpolation while allowing special chars in commands
bcb2640 
fixes #22176, see also #20494 and #20482
@StefanKarpinski StefanKarpinski mentioned this issue Jun 17, 2017
Closed
StefanKarpinski added a commit that referenced this issue Jun 17, 2017
@StefanKarpinski
fix shell mode interpolation while allowing special chars in commands
7062315 
fixes #22176, see also #20494 and #20482
StefanKarpinski added a commit that referenced this issue Jun 17, 2017
@StefanKarpinski
fix shell mode interpolation & allow special chars in commands
6eaf550 
fixes #22176, see also #20494 and #20482
StefanKarpinski added a commit that referenced this issue Jun 18, 2017
@StefanKarpinski
fix shell mode interpolation while allowing special chars in commands
cb212f2 
fixes #22176, see also #20494 and #20482
StefanKarpinski added a commit that referenced this issue Jun 18, 2017
@StefanKarpinski
fix shell mode interpolation & allow special chars in commands
6198ba9 
fixes #22176, see also #20494 and #20482
@StefanKarpinski StefanKarpinski mentioned this issue Jun 18, 2017
Merged
StefanKarpinski added a commit that referenced this issue Jun 18, 2017
@StefanKarpinski
fix shell mode interpolation & allow special chars in commands
97d78cb 
fixes #22176, see also #20494 and #20482
StefanKarpinski added a commit that referenced this issue Jun 18, 2017
@StefanKarpinski
fix shell mode interpolation & allow special chars in commands
13451fe 
fixes #22176, see also #20494 and #20482
StefanKarpinski added a commit that referenced this issue Jun 18, 2017
@StefanKarpinski
fix shell mode interpolation & allow special chars in commands
c49abd7 
fixes #22176, see also #20494 and #20482
tkelman pushed a commit that referenced this issue Jun 18, 2017
@StefanKarpinski @tkelman
fix shell mode interpolation & allow special chars in commands
4e06773 
fixes #22176, see also #20494 and #20482

(cherry picked from commit c49abd7)
ref #22413
quinnj pushed a commit that referenced this issue Jun 20, 2017
@StefanKarpinski @quinnj
fix shell mode interpolation & allow special chars in commands
a05bf52 
fixes #22176, see also #20494 and #20482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanKarpinski StefanKarpinski

Labels
kind:regression Regression in behavior compared to a previous version stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
0.6.x
Development

Successfully merging a pull request may close this issue.

fix shell mode interpolation & allow special chars in commands JuliaLang/julia
5 participants
@StefanKarpinski @JeffBezanson @giordano @tkelman @samuelpowell