Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge strwidth and charwidth to textwidth #23667

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Merge strwidth and charwidth to textwidth #23667

merged 1 commit into from
Sep 23, 2017

Conversation

TotalVerb
Copy link
Contributor

Closes #20816.

@ararslan ararslan added the domain:strings "Strings!" label Sep 11, 2017
@TotalVerb
Copy link
Contributor Author

Fixed a (seemingly untested?) mistake with the rewrite of strwidth into a sum instead of an explicit loop. This should be squashed when merging.

@ararslan
Copy link
Member

The CI failures are doc stuff; I think you'll have to remove the doc references to charwidth and strwidth and add textwidth.

@JeffBezanson
Copy link
Sponsor Member

Needs a rebase.

@StefanKarpinski StefanKarpinski added the status:triage This should be discussed on a triage call label Sep 22, 2017
@TotalVerb
Copy link
Contributor Author

Sorry for the delay here, the documentation build failures were confusing me. I'll check Documenter out and see what's up.

@JeffBezanson JeffBezanson removed the status:waiting for author Anybody home? label Sep 23, 2017
@KristofferC KristofferC merged commit 19921aa into JuliaLang:master Sep 23, 2017
@StefanKarpinski StefanKarpinski removed the status:triage This should be discussed on a triage call label Oct 5, 2017
@nalimilan nalimilan mentioned this pull request Nov 6, 2017
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@stevengj stevengj stevengj approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
domain:strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TotalVerb @ararslan @JeffBezanson @stevengj @StefanKarpinski @KristofferC