move Dates to stdlib #24459
move Dates to stdlib #24459
Conversation
KristofferC
added
domain:dates
KristofferC
force-pushed
the
kc/move_dates
branch
from
1b0c3c0
to
312a035
Compare
|
|
| @@ -473,6 +469,7 @@ unshift!(Base._included_files, (@__MODULE__, joinpath(@__DIR__, "sysimg.jl"))) | |||
| # load some stdlib packages but don't put their names in Main | |||
| Base.require(:DelimitedFiles) | |||
| Base.require(:Test) | |||
| Base.require(:Dates) | |||
There was a problem hiding this comment.
What decides if an stdlib package should be required here or not?
There was a problem hiding this comment.
Anyone know the answer here? @JeffBezanson?
There was a problem hiding this comment.
These are to reduce startup/load time.
KristofferC
force-pushed
the
kc/move_dates
branch
5 times, most recently
from
6ee33bd
to
9d466fe
Compare
KristofferC
force-pushed
the
kc/move_dates
branch
3 times, most recently
from
a819a7d
to
3830f66
Compare
|
I worked around the "LibGit2 using Dates"-problem in either, depending on your inclination, a brilliant or horrible way. |
base/libgit2/signature.jl
Outdated
| function Base.show(io::IO, sig::Signature) | ||
| print(io, "Name: ", sig.name, ", ") | ||
| print(io, "Email: ", sig.email, ", ") | ||
| print(io, "Time: ", Dates.unix2datetime(sig.time + 60*sig.time_offset)) | ||
| print(io, "Time: ", unix2datetime[](sig.time + 60*sig.time_offset)) |
There was a problem hiding this comment.
how about
function yearmonthday(days)
z = days + 306; h = 100z - 25; a = fld(h, 3652425); b = a - fld(a, 4)
y = fld(100b + h, 36525); c = b + z - 365y - fld(y, 4); m = div(5c + 456, 153)
d = c - div(153m - 457, 5); return m > 12 ? (y + 1, m - 12, d) : (y, m, d)
end
lpad0(x) = lpad(x, 2, '0')
function printunix(io, t)
UNIXEPOCH = 62135683200000
rata = UNIXEPOCH + round(Int64, Int64(1000) * t)
year, month, day = yearmonthday(fld(rata, 86400000))
secs = t % (24 * 60 * 60)
mins = div(secs, 60)
m, d = lpad0(month), lpad0(day)
h, mi, s = lpad0(div(mins, 60)), lpad0(mins % 60), lpad0(secs % 60)
print(io, "$year-$m-$d $h:$mi:$s")
end
KristofferC
force-pushed
the
kc/move_dates
branch
from
264a35e
to
c962ecc
Compare
|
Ok, I added the functions @quinnj with some modifications (truncating stuff to Integers). If tests pass and this looks OK to you, this is ready to merge from my pov. |
|
Travis OSX failure is spawn, I'm guessing appveyor |
| @@ -198,6 +198,7 @@ for N in [0,10] | |||
| end | |||
|
|
|||
| # Testing timedwait on multiple channels | |||
| using Dates | |||
There was a problem hiding this comment.
Will this cause problems if someone builds julia w/o the Dates module? I guess these tests would fail?
There was a problem hiding this comment.
Yes, but it is sort of the same if someone is building without Base64 though, right? I think for now, we don't have the requirement that arbitrary stdlib modules can be excluded.
| @@ -3306,6 +3306,7 @@ end | |||
| @test Tuple{Int} === Tuple{Int, Vararg{Integer, 0}} | |||
|
|
|||
| # issue #12003 | |||
| using Dates | |||
There was a problem hiding this comment.
same here; I think it'd be generally preferable to not have Core/Base tests depend on stdlib modules, but I guess this is ok for now.
There was a problem hiding this comment.
How about the Test stdlib module? 
| include("types.jl") | ||
| include("io.jl") | ||
| include("arithmetic.jl") | ||
| include("conversions.jl") |
There was a problem hiding this comment.
Shouldn't we have a @testset "Dates" begin wrapping all of this?
Not completely done yet.
(Also removed 0.6 Dates deprecations, 0.7 deprecations moved to stdlib).
Fix #23302