Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22018: make finalizer(f, x) return x rather than nothing #24679

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Nov 21, 2017

This pull request makes finalizer(f, x) return x rather than nothing, addressing #22018.

I found only two calls to finalizer that make use of the return value. Both calls are of the form islocked(...) && return finalizer(..., ...), which I've naively rewritten islocked(...) && (finalizer(...); return nothing). Not being familiar with the associated code I cannot assess whether this rewrite is reasonable. Best!

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 21, 2017

Rebased with #24605 in. Absent objections or requests for time, I plan to merge these changes this evening (PT) or later. Best!

@Sacha0 Sacha0 changed the title [WIP] 22018: make finalizer(f, x) return x rather than nothing 22018: make finalizer(f, x) return x rather than nothing Nov 21, 2017
@Sacha0 Sacha0 merged commit a2fa248 into JuliaLang:master Nov 22, 2017
@Sacha0 Sacha0 deleted the finret branch November 22, 2017 04:22
@Sacha0
Copy link
Member Author

Sacha0 commented Nov 22, 2017

Thanks all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants