Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create UUIDs stdlib package #25819

Merged
merged 1 commit into from
Jan 31, 2018
Merged

create UUIDs stdlib package #25819

merged 1 commit into from
Jan 31, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

closes #25590

@JeffBezanson JeffBezanson added the stdlib Julia's standard library label Jan 30, 2018
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 30, 2018

Looking at the PR, this seems like too much code division. I think we should just keep these couple of functions in Random.

@JeffBezanson
Copy link
Sponsor Member Author

But nothing else in Random has to do with UUIDs, and nothing in UUIDs has to do with random number generation (it's only a user of it). I don't see why those would need to be grouped together.

@StefanKarpinski
Copy link
Sponsor Member

Also, this is going to end up being a package that implements all five UUID generation methods and therefore depends on SHA and MD5 (which will be, as discussed, moved into stdlib). Presumably one doesn't want Random to gratuitously depend on those packages at that point.

@JeffBezanson JeffBezanson merged commit 0f95988 into master Jan 31, 2018
@JeffBezanson JeffBezanson deleted the jb/uuid branch January 31, 2018 03:25
@oxinabox
Copy link
Contributor

Shall a new issue be created: "Add UUID-XYZ functionality to stdlib",
with move SHA.jl and MD5.jl as subtasks?

@StefanKarpinski
Copy link
Sponsor Member

Sure. I would make the tasks "UUID: add uuid3", etc.

@oxinabox oxinabox mentioned this pull request Feb 1, 2018
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

what to do with UUID?
4 participants
@JeffBezanson @vtjnash @StefanKarpinski @oxinabox