Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoud dotview be documented? #31729

Open
oxinabox opened this issue Apr 15, 2019 · 1 comment
Open

shoud dotview be documented? #31729

oxinabox opened this issue Apr 15, 2019 · 1 comment
Labels
broadcast Applying a function over a collection doc This change adds or pertains to documentation

Comments

@oxinabox
Copy link
Contributor

I found that to make x[:, y=2] .= 7 to work,
I needed to overload Base.dotview for my array type.
(see invenia/NamedDims.jl#1)

Which is not documented on the broadcasting docs page.
It does have a non-docstring comment above it, that mostly explained things.

@mbauman
Copy link
Sponsor Member

mbauman commented Apr 15, 2019

It shouldn't be something you need to override. I think its base implementation should just forward any kwargs to view/getindex by default, which would solve your problem.

That said, it is something that gets generated by lowering, and it is exported from Broadcast, so it'd be good to document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection doc This change adds or pertains to documentation
Projects
None yet
Development

No branches or pull requests

2 participants