Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing tab-completion help for emoji #34006

Closed
stevengj opened this issue Dec 2, 2019 · 2 comments · Fixed by #34034
Closed

missing tab-completion help for emoji #34006

stevengj opened this issue Dec 2, 2019 · 2 comments · Fixed by #34034
Labels
bug Indicates an unexpected problem or unintended behavior good first issue Indicates a good issue for first-time contributors to Julia REPL Julia's REPL (Read Eval Print Loop)

Comments

@stevengj
Copy link
Member

stevengj commented Dec 2, 2019

As reported on discourse, the REPL help doesn't show tab completion info for emoji even when it exists, unlike for other Unicode completions:

help?> α
"α" can be typed by \alpha<tab>
search:

Couldn't find α
Perhaps you meant !, %, &, *, +, -, /, :, <, >, \, ^, |, ~, ÷, π, ℯ, ,  or 
  No documentation found.

  Binding α does not exist.

help?> 👍
search:

Couldn't find 👍
Perhaps you meant !, %, &, *, +, -, /, :, <, >, \, ^, |, ~, ÷, π, ℯ, ,  or 
  No documentation found.

  Binding 👍 does not exist.

even though 👍 is produced by tab completion of \:+1:

@stevengj stevengj added bug Indicates an unexpected problem or unintended behavior REPL Julia's REPL (Read Eval Print Loop) labels Dec 2, 2019
@stevengj
Copy link
Member Author

stevengj commented Dec 2, 2019

The reason for this is that the emoji completions are in a separate list REPL.REPLCompletions.emoji_symbols from the latex completions REPL.REPLCompletions.latex_symbols for some reason, but the completions help only uses the latter.

Should be trivial to fix. For example, it would be enough to just replace this line with

for (k,v) in Iterators.flatten((Base.REPL_MODULE_REF[].REPLCompletions.latex_symbols,
                                Base.REPL_MODULE_REF[].REPLCompletions.emoji_symbols))

@stevengj stevengj added the good first issue Indicates a good issue for first-time contributors to Julia label Dec 2, 2019
@utkarsh2102
Copy link
Contributor

I'll take a stab at this 🌮

utkarsh2102 added a commit to utkarsh2102/julia that referenced this issue Dec 6, 2019
stevengj pushed a commit to utkarsh2102/julia that referenced this issue Aug 29, 2020
stevengj added a commit that referenced this issue Aug 30, 2020
* Add missing tab-completion help for emoji

Closes: #34006

* Add tests for tab-completion on emoji

* Drop Base.REPL_MODULE_REF[] as it is a part of REPL

* Use colons

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

* Update docview.jl

* fix test

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior good first issue Indicates a good issue for first-time contributors to Julia REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants