Fix sizeof for non-Array subarrays
#36715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhoh, now that I think about it this opens a bigger can of worms. When the dimension 1 stride is not 1, we write elements individually (no alignment padding), and otherwise in memory chunks (yes alignment padding). For SubArrays of Arrays, we should probably change that to always include the padding. I can open a separate PR for that. Similarly, there might be many other types besides Array that need to use |
JeffBezanson
pushed a commit
that referenced
this pull request
Jul 21, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all
AbstractArrays define elsize. Cf. #35900, #36714.