Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overflow detection in parseint #4874

Closed
StefanKarpinski opened this issue Nov 20, 2013 · 0 comments
Closed

overflow detection in parseint #4874

StefanKarpinski opened this issue Nov 20, 2013 · 0 comments
Labels
status:help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@StefanKarpinski
Copy link
Sponsor Member

See discussion: https://groups.google.com/forum/#!topic/julia-users/8BP1Mt1o_r0

Here's where the overflow detection needs to go:

julia/base/string.jl

Line 1472 in 704b852

# TODO: overflow detection?

StefanKarpinski added a commit that referenced this issue Nov 21, 2013
@StefanKarpinski
Base.checked_{add,sub,mul}: checked versions of +, - and * [fix #4874]
6c08baa 
We've had the intrinsics for checked arithmetic for a rather long time,
we just haven't used it anywhere. This defines checked +, - and * the
same way that we define +, - and * and uses it in parseint to prevent
overflow when attempting to parse a too-large value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StefanKarpinski